HyukjinKwon commented on a change in pull request #34559: URL: https://github.com/apache/spark/pull/34559#discussion_r748779639
########## File path: python/pyspark/sql/session.py ########## @@ -287,7 +287,12 @@ def getOrCreate(self) -> "SparkSession": _instantiatedSession: ClassVar[Optional["SparkSession"]] = None _activeSession: ClassVar[Optional["SparkSession"]] = None - def __init__(self, sparkContext: SparkContext, jsparkSession: Optional[JavaObject] = None): + def __init__( + self, + sparkContext: SparkContext, + jsparkSession: Optional[JavaObject] = None, + options: Optional[Dict[str, Any]] = None, + ): Review comment: Yeah I don't think this is breaking. Let me double check closely by tmr EODbut from a coursory look it seems fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org