Github user sryza commented on the pull request:

    https://github.com/apache/spark/pull/3913#issuecomment-100676458
  
    @pwendell @rxin if we're putting it in the same package, I don't really 
understand why we don't just have a single class `SizeEstimator` with a single 
public method `estimate`?  We're worried in the future that someone might make 
other attributes of `SizeEstimator` public?  I don't see why we wouldn't trust 
ourselves to properly restrict access when a change proposing that comes 
around.  Or, in `SizeEstimator` / `SizeEstimator0` world, it wouldn't be just 
as easy to add something public to `SizeEstimator`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to