Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6029#discussion_r30005639
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -573,10 +573,19 @@ object ApplicationMaster extends Logging {
       }
     
       private[spark] def sparkContextInitialized(sc: SparkContext): Unit = {
    +    if(master == null) {
    --- End diff --
    
    (Should be a space after `if` but that can be fixed on merge; might fix 
that if you make any other change.) 
    
    I think the text is OK although I suppose that as of 1.4 there's the 
launcher API, but, probably not worth writing a man page here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to