HyukjinKwon commented on a change in pull request #34593:
URL: https://github.com/apache/spark/pull/34593#discussion_r748940492
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala
##########
@@ -319,6 +370,18 @@ class MathFunctionsSuite extends QueryTest with
SharedSparkSession {
df.withColumn("value_brounded", bround('value)),
Seq(Row(BigDecimal("5.9"), BigDecimal("6")))
)
+ checkAnswer(
+ df.withColumn("value_rounded", round('value, 0, "up")),
+ Seq(Row(BigDecimal("5.9"), BigDecimal("6")))
+ )
+ checkAnswer(
+ df.withColumn("value_brounded", round('value, 0, "down")),
Review comment:
Can we match the argument and usage with other references? I think we
don't have to bother to come up with spark's own argument style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
