jerqi commented on a change in pull request #34589:
URL: https://github.com/apache/spark/pull/34589#discussion_r748962655



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
##########
@@ -212,6 +212,13 @@ class WholeStageCodegenSuite extends QueryTest with 
SharedSparkSession
       Seq(Row(0, 0, 0), Row(1, 1, null), Row(2, 2, 2), Row(3, 3, null), Row(4, 
4, null),
         Row(null, 5, null), Row(null, 6, null), Row(null, 7, null), Row(null, 
8, null),
         Row(null, 9, null), Row(null, null, 1)))
+
+    // test join with Aggregate
+    val joinWithAggregateDF = df1.join(df2.hint("SHUFFLE_HASH"), $"k1" === 
$"k2", "full_outer")
+    assert(joinWithAggregateDF.queryExecution.executedPlan.collect {
+      case WholeStageCodegenExec(_ : ShuffledHashJoinExec) => true
+    }.size === 1)
+    assert(joinWithAggregateDF.count() === 10)

Review comment:
       Ok, I will fix. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to