cloud-fan commented on a change in pull request #33588:
URL: https://github.com/apache/spark/pull/33588#discussion_r749245815
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -286,15 +287,25 @@ object OrcUtils extends Logging {
def getInnerTypeDecription(dt: DataType): Option[TypeDescription] = {
dt match {
case y: YearMonthIntervalType =>
- val typeDesc = orcTypeDescription(IntegerType)
+ val typeDesc = new TypeDescription(TypeDescription.Category.INT)
typeDesc.setAttribute(
CATALYST_TYPE_ATTRIBUTE_NAME, y.typeName)
Some(typeDesc)
case d: DayTimeIntervalType =>
- val typeDesc = orcTypeDescription(LongType)
+ val typeDesc = new TypeDescription(TypeDescription.Category.LONG)
typeDesc.setAttribute(
CATALYST_TYPE_ATTRIBUTE_NAME, d.typeName)
Some(typeDesc)
+ case n: TimestampNTZType =>
+ val typeDesc = new
TypeDescription(TypeDescription.Category.TIMESTAMP)
+ typeDesc.setAttribute(
+ CATALYST_TYPE_ATTRIBUTE_NAME, n.typeName)
Review comment:
```suggestion
typeDesc.setAttribute(CATALYST_TYPE_ATTRIBUTE_NAME, n.typeName)
```
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -286,15 +287,25 @@ object OrcUtils extends Logging {
def getInnerTypeDecription(dt: DataType): Option[TypeDescription] = {
dt match {
case y: YearMonthIntervalType =>
- val typeDesc = orcTypeDescription(IntegerType)
+ val typeDesc = new TypeDescription(TypeDescription.Category.INT)
typeDesc.setAttribute(
CATALYST_TYPE_ATTRIBUTE_NAME, y.typeName)
Some(typeDesc)
case d: DayTimeIntervalType =>
- val typeDesc = orcTypeDescription(LongType)
+ val typeDesc = new TypeDescription(TypeDescription.Category.LONG)
typeDesc.setAttribute(
CATALYST_TYPE_ATTRIBUTE_NAME, d.typeName)
Some(typeDesc)
+ case n: TimestampNTZType =>
+ val typeDesc = new
TypeDescription(TypeDescription.Category.TIMESTAMP)
+ typeDesc.setAttribute(
+ CATALYST_TYPE_ATTRIBUTE_NAME, n.typeName)
+ Some(typeDesc)
+ case t: TimestampType =>
+ val typeDesc = new
TypeDescription(TypeDescription.Category.TIMESTAMP)
+ typeDesc.setAttribute(
+ CATALYST_TYPE_ATTRIBUTE_NAME, t.typeName)
Review comment:
```suggestion
typeDesc.setAttribute(CATALYST_TYPE_ATTRIBUTE_NAME, t.typeName)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
