beliefer commented on a change in pull request #34554:
URL: https://github.com/apache/spark/pull/34554#discussion_r749478053



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -193,6 +195,85 @@ abstract class JdbcDialect extends Serializable with 
Logging{
     case _ => value
   }
 
+  /**
+   * Turns a single Filter into a String representing a SQL expression.
+   * Returns None for an unhandled filter.
+   */
+  @Since("3.3.0")
+  def compileFilter(f: Filter): Option[String] = {

Review comment:
       First, database A and B implement a different number of aggregate 
functions that meet the SQL standard.
   Second, some database implement some aggregate functions that not meet the 
SQL standard.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to