c21 edited a comment on pull request #34612: URL: https://github.com/apache/spark/pull/34612#issuecomment-970654570
> do we need to update the codegen side as well? @cloud-fan - for code-gen, we don't need to update. I intentionally [avoided the unnecessary buffer and copy, and directly output rows in code-gen](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala#L1026-L1034), when creating code-gen PR. I noticed this performance opportunity when working on code-gen PR, so fixing here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
