zinking commented on a change in pull request #18440:
URL: https://github.com/apache/spark/pull/18440#discussion_r751049019
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -138,8 +138,12 @@ case class RowDataSourceScanExec(
}
// Only care about `relation` and `metadata` when canonicalizing.
- override def preCanonicalized: SparkPlan =
- copy(rdd = null, outputPartitioning = null, metastoreTableIdentifier =
None)
+ override lazy val canonicalized: SparkPlan =
+ copy(
+ output.map(QueryPlan.normalizeExprId(_, output)),
+ rdd = null,
+ outputPartitioning = null,
+ metastoreTableIdentifier = None)
Review comment:
> `relation: BaseRelation` will take care of the equality check.
Besides, the old `preCanonicalized` already set `metastoreTableIdentifier` to
None.
thanks for the reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
