peter-toth edited a comment on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-971701416
> @peter-toth Regarding my review I found mostly just Nits and has one refactoring idea which goes through on multiple methods (I will share with you by a PR against this one). Thanks for the comments and suggestion @attilapiros! Since your last review I've improved generic node merging: https://github.com/apache/spark/pull/32298/commits/cc8690edf34297b1f4948f0221963d21eccffa5a and also added https://github.com/apache/spark/pull/32298/commits/dabbea4b1b4975828486e5abb5879410c0b8294c as a negative case to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
