holdenk commented on a change in pull request #34599:
URL: https://github.com/apache/spark/pull/34599#discussion_r751635345
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KubernetesFeatureConfigStep.scala
##########
@@ -70,7 +70,15 @@ trait KubernetesFeatureConfigStep {
/**
* Return any additional Kubernetes resources that should be added to
support this feature. Only
- * applicable when creating the driver in cluster mode.
+ * applicable when creating the driver in cluster mode. Resources would be
setup/refresh after
+ * Pod creating.
Review comment:
nit s:/creating/creation/.
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KubernetesFeatureConfigStep.scala
##########
@@ -70,7 +70,15 @@ trait KubernetesFeatureConfigStep {
/**
* Return any additional Kubernetes resources that should be added to
support this feature. Only
- * applicable when creating the driver in cluster mode.
+ * applicable when creating the driver in cluster mode. Resources would be
setup/refresh after
+ * Pod creating.
*/
def getAdditionalKubernetesResources(): Seq[HasMetadata] = Seq.empty
+
+ /**
+ * Return any additional Kubernetes resources that should be added to
support this feature. Only
+ * applicable when creating the driver in cluster mode. Resources would be
setup/refresh before
+ * Pod creating.
Review comment:
nit s:/creating/creation/.
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -133,6 +133,10 @@ private[spark] class Client(
.build()
val driverPodName = resolvedDriverPod.getMetadata.getName
+ // setup resources before pod create
Review comment:
same nit s/create/creation/ (or you could also s/before pod
create/before creating pod/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
