Peng-Lei commented on a change in pull request #32340:
URL: https://github.com/apache/spark/pull/32340#discussion_r751888117
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
##########
@@ -172,6 +176,10 @@ public ArrowColumnVector(ValueVector vector) {
}
} else if (vector instanceof NullVector) {
accessor = new NullAccessor((NullVector) vector);
+ } else if (vector instanceof IntervalYearVector) {
+ accessor = new IntervalYearAccessor((IntervalYearVector) vector);
+ } else if (vector instanceof IntervalDayVector) {
+ accessor = new IntervalDayAccessor((IntervalDayVector) vector);
Review comment:
I'm not quite sure why `DayTimeIntervalType` map Arrow's `IntervalType`
here. just according
[ArrowUtils.scala#L60](https://github.com/apache/spark/blob/4ed2dab5ee46226f29919eba05fe52e446ab2449/sql/catalyst/src/main/scala/org/apache/spark/sql/util/ArrowUtils.scala#L60).
I try to learn about [Arrow
types](https://arrow.apache.org/docs/cpp/api/datatype.html). it's sql style.
And in hive `INTERVAL_DAY_TIME` map arrow's `IntervalType` with
`IntervalUnit.DAY_TIME` unit. If we map `DayTimeIntervalType` to Arrow's
`DurationType `. Then which type `YearMonthIntervalType` to match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
