Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r12502145
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1045,6 +1045,9 @@ private[spark] object BlockManager extends Logging {
def getMaxMemory(conf: SparkConf): Long = {
val memoryFraction = conf.getDouble("spark.storage.memoryFraction",
0.6)
+ if (memoryFraction > 1 && memoryFraction < 0) {
--- End diff --
Should throw an IllegalArgumentException exception
```scala
Preconditions.checkArgument(0 < memoryFraction && 1 > memoryFraction,
"spark.storage.memoryFraction should be between 0 and 1.")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
