cloud-fan commented on a change in pull request #32875:
URL: https://github.com/apache/spark/pull/32875#discussion_r753217488
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -330,6 +339,15 @@ case class PartitioningCollection(partitionings:
Seq[Partitioning])
override def satisfies0(required: Distribution): Boolean =
partitionings.exists(_.satisfies(required))
+ override def createShuffleSpec(
+ defaultNumPartitions: Int,
+ distribution: ClusteredDistribution): ShuffleSpec = {
+ require(satisfies(distribution), "createShuffleSpec should only be called
after satisfies " +
Review comment:
shall we let the caller side do this check? it's a bit weird that only
`PartitioningCollection` have this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
