c21 commented on a change in pull request #34670:
URL: https://github.com/apache/spark/pull/34670#discussion_r753526343
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -1666,9 +1677,14 @@ case class WidthBucket(
}
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
- defineCodeGen(ctx, ev, (input, min, max, numBucket) =>
- "org.apache.spark.sql.catalyst.expressions.WidthBucket" +
- s".computeBucketNumber($input, $min, $max, $numBucket)")
+ nullSafeCodeGen(ctx, ev, (input, min, max, numBucket) => {
Review comment:
Oh I see, got it. @tomvanbussel thanks for explanation.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -1666,9 +1677,14 @@ case class WidthBucket(
}
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
- defineCodeGen(ctx, ev, (input, min, max, numBucket) =>
- "org.apache.spark.sql.catalyst.expressions.WidthBucket" +
- s".computeBucketNumber($input, $min, $max, $numBucket)")
+ nullSafeCodeGen(ctx, ev, (input, min, max, numBucket) => {
Review comment:
Oh I see, got it. @tomvanbussel thanks for explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
