nchammas commented on a change in pull request #34671:
URL: https://github.com/apache/spark/pull/34671#discussion_r753568842
##########
File path: python/mypy.ini
##########
@@ -41,9 +41,15 @@ disallow_untyped_defs = False
[mypy-pyspark.join]
disallow_untyped_defs = False
+[mypy-pyspark.ml.*]
+disallow_untyped_defs = False
+
Review comment:
Okie doke. I was trying to stick to the annotations that were already in
the `.pyi` files, but I will go ahead an add the missing return types to all
functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]