sadikovi commented on a change in pull request #34659:
URL: https://github.com/apache/spark/pull/34659#discussion_r753865400
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java
##########
@@ -176,8 +176,7 @@ public void initBatch(
// Initialize the missing columns once.
if (colId == -1) {
OnHeapColumnVector missingCol = new OnHeapColumnVector(capacity, dt);
- missingCol.putNulls(0, capacity);
- missingCol.setIsConstant();
+ missingCol.setAllNull();
Review comment:
Oh, almost forgot to ask.
Is `missingCol.setAllNull();` equivalent to
```
missingCol.putNulls(0, capacity);
missingCol.setIsConstant();
```
? I thought `setAllNull` was an alias for the two method calls but it does
not appear to be the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
