Peng-Lei commented on a change in pull request #34666:
URL: https://github.com/apache/spark/pull/34666#discussion_r754023053



##########
File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql
##########
@@ -1,26 +0,0 @@
--- create a table with properties
-CREATE TABLE tbl (a INT, b STRING, c INT) USING parquet
-TBLPROPERTIES('p1'='v1', 'p2'='v2');
-
-SHOW TBLPROPERTIES tbl;
-SHOW TBLPROPERTIES tbl("p1");
-SHOW TBLPROPERTIES tbl("p3");
-
-DROP TABLE tbl;
-
--- create a view with properties
-CREATE VIEW view TBLPROPERTIES('p1'='v1', 'p2'='v2') AS SELECT 1 AS c1;

Review comment:
       I think 
[here](https://github.com/apache/spark/blob/06586f681bb72c4ad48ef9203e290d75b2732670/sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTblPropertiesSuite.scala#L50)
 cover the view test. but just for v1.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to