attilapiros commented on pull request #34672: URL: https://github.com/apache/spark/pull/34672#issuecomment-975279827
In this case there will be a problem when somebody would like to use the external shuffle service with a customized shuffle manager (like with some minor version of the `SortShuffleManager`). I do not know how valid this use case is but we can come around it in the following way: What about extending `ShuffleManager` trait with a new method indicating whether this shuffle manager implementation works with the external shuffle manager or not. It can have a default implementation giving back true and only needed to be overridden when the external shuffle manager is not supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
