sathiyapk commented on a change in pull request #34675:
URL: https://github.com/apache/spark/pull/34675#discussion_r754117933
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -59,7 +59,10 @@ trait TimeZoneAwareExpression extends Expression {
/** Returns a copy of this expression with the specified timeZoneId. */
def withTimeZone(timeZoneId: String): TimeZoneAwareExpression
- @transient lazy val zoneId: ZoneId = DateTimeUtils.getZoneId(timeZoneId.get)
Review comment:
And moreover, calling `.get` on an Option variable never been a good
practise which may leads to un-meaningful error messages. We should always use
`.getOrElse` on an Option variable. So i propose either we use
`.getOrElse(TimeZone.getDefault)` or `.getOrElse(throw
UnSupportedUsageExpection("..."))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
