sarutak commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r754325315



##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
         </os>
       </activation>
     </profile>
+    <profile>
+      <id>mac-on-apple-silicon</id>
+      <properties>
+        
<test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>

Review comment:
       > So is it necessary for us to remind developers using M1 that they 
should manually add these tags when testing?
   
   If users want to set `-Dtest.default.exclude.tags` manually (e.g. for 
removing `ChromeUITest` tag), they still need to know about 
`Extended{LevelDB,RocksDB}Test` tags because the default value of 
`test.default.exclude.tags` set by the `mac-on-apple-silicon` profile is 
overridden.
   
   So, another option would be to note how to test using Apple silicon on [the 
developer's doc](http://spark.apache.org/developer-tools.html).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to