sarutak commented on a change in pull request #34647:
URL: https://github.com/apache/spark/pull/34647#discussion_r754268757
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2659,6 +2660,19 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-36180: Support TimestampNTZ type in Hive") {
+ withTable("tb") {
+ val dt = "2018-11-17 13:33:33.0"
+ val ddl =
+ s"CREATE TABLE tb as SELECT TIMESTAMP_LTZ'$dt' as c0, TIMESTAMP_NTZ
'$dt' as c1"
Review comment:
~~Yeah, it's a Hive's limitation. So, Spark can't support
`timestamp_ntz` for Hive provider.~~
~~If a user needs to store a table which contains `timestamp_ntz` as a Hive
table, the user should manually convert `timestamp_ntz` to `timestamp` if it's
really necessary.~~
I misunderstood that Hive's timestamp is ltz. The option 1 seems better in
that it makes Spark keep simple. But how much is the benefit of option 2 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
