imback82 commented on a change in pull request #34610: URL: https://github.com/apache/spark/pull/34610#discussion_r754764231
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterNamespaceSetLocationSuiteBase.scala ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command + +import org.apache.spark.sql.{AnalysisException, QueryTest} +import org.apache.spark.sql.connector.catalog.SupportsNamespaces + +/** + * This base suite contains unified tests for the `ALTER NAMESPACE ... SET LOCATION` command that + * check V1 and V2 table catalogs. The tests that cannot run for all supported catalogs are located + * in more specific test suites: + * + * - V2 table catalog tests: + * `org.apache.spark.sql.execution.command.v2.AlterNamespaceSetLocationSuite` + * - V1 table catalog tests: + * `org.apache.spark.sql.execution.command.v1.AlterNamespaceSetLocationSuiteBase` + * - V1 In-Memory catalog: + * `org.apache.spark.sql.execution.command.v1.AlterNamespaceSetLocationSuite` + * - V1 Hive External catalog: + * `org.apache.spark.sql.hive.execution.command.AlterNamespaceSetLocationSuite` + */ +trait AlterNamespaceSetLocationSuiteBase extends QueryTest with DDLCommandTestUtils { + override val command = "ALTER NAMESPACE ... SET LOCATION" + + protected def namespace: String + + protected def notFoundMsgPrefix: String + + test("Namespace does not exist") { + val ns = "not_exist" + val message = intercept[AnalysisException] { + sql(s"ALTER DATABASE $catalog.$ns SET LOCATION 'loc'") + }.getMessage + assert(message.contains(s"$notFoundMsgPrefix '$ns' not found")) + } + + // Hive catalog does not support "ALTER NAMESPACE ... SET LOCATION", thus + // this is called from non-Hive v1 and v2 tests. + protected def runBasicTest(): Unit = { + val ns = s"$catalog.$namespace" + withNamespace(ns) { + sql(s"CREATE NAMESPACE IF NOT EXISTS $ns COMMENT " + + "'test namespace' LOCATION '/tmp/loc_test_1'") + sql(s"ALTER NAMESPACE $ns SET LOCATION '/tmp/loc_test_2'") + // v1 command stores the location as URI ("file:/tmp/loc_test_2") whereas + // v2 command stores the location as string ("/tmp/loc_test_2"). Review comment: Created https://github.com/apache/spark/pull/34686 to fix the behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
