sadikovi commented on a change in pull request #34611:
URL: https://github.com/apache/spark/pull/34611#discussion_r754789534
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
##########
@@ -130,6 +133,89 @@ class ColumnarBatchSuite extends SparkFunSuite {
}
}
+ testVector("Boolean APIs", 1024, BooleanType) {
+ column =>
+ val reference = mutable.ArrayBuffer.empty[Boolean]
+
+ var values = Array(true, false, true, false, false)
+ var bits = values.foldRight(0)((b, i) => i << 1 | (if (b) 1 else
0)).toByte
+ column.appendBooleans(2, bits, 0)
+ reference ++= values.slice(0, 2)
+
+ column.appendBooleans(3, bits, 2)
+ reference ++= values.slice(2, 5)
+
+ column.appendBooleans(6, true)
+ reference ++= Array.fill(6)(true)
+
+ column.appendBoolean(false)
+ reference += false
+
+ var idx = column.elementsAppended
+
+ values = Array(true, true, false, true, false, true, false, true)
+ bits = values.foldRight(0)((b, i) => i << 1 | (if (b) 1 else 0)).toByte
+ column.putBooleans(idx, 2, bits, 0)
+ reference ++= values.slice(0, 2)
+ idx += 2
+
+ column.putBooleans(idx, 3, bits, 2)
+ reference ++= values.slice(2, 5)
+ idx += 3
+
+ column.putBooleans(idx, bits)
+ reference ++= values
+ idx += 8
+
+ column.putBoolean(idx, false)
+ reference += false
+ idx += 1
+
+ column.putBooleans(idx, 3, true)
+ reference ++= Array.fill(3)(true)
+ idx += 3
+
+ implicit def intToByte(i: Int): Byte = i.toByte
+ val buf = ByteBuffer.wrap(Array(0x33, 0x5A, 0xA5, 0xCC, 0x0F, 0xF0,
0xEE))
+ val reader = new VectorizedPlainValuesReader()
+ reader.initFromPage(0, ByteBufferInputStream.wrap(buf))
+ column.putBoolean(idx, reader.readBoolean) // bit index 0
+ reference += true
+ idx += 1
+
+ reader.skipBooleans(1)
+
+ column.putBoolean(idx, reader.readBoolean) // bit index 2
+ reference += false
+ idx += 1
+
+ reader.skipBooleans(5)
+
+ column.putBoolean(idx, reader.readBoolean) // bit index 8
+ reference += false
+ idx += 1
+
+ reader.skipBooleans(8)
Review comment:
We need to add a check to make sure the operation was a no-op, not just
adding a call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
