cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r754984133
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ########## @@ -349,7 +351,7 @@ case class SetNamespaceProperties( */ case class SetNamespaceLocation( namespace: LogicalPlan, - location: String) extends UnaryCommand { + location: URI) extends UnaryCommand { Review comment: and can you refer to the code for qualifying the path string in v1 commands? Let's make sure v1 and v2 are truly consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org