srowen commented on a change in pull request #34692:
URL: https://github.com/apache/spark/pull/34692#discussion_r755635322
##########
File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
##########
@@ -33,10 +33,9 @@ import org.apache.spark.util.collection.OpenHashSet
/**
* A trait that allows a class to give [[SizeEstimator]] more accurate size
estimation.
- * When a class extends it, [[SizeEstimator]] will query the `estimatedSize`
first.
- * If `estimatedSize` does not return `None`, [[SizeEstimator]] will use the
returned size
- * as the size of the object. Otherwise, [[SizeEstimator]] will do the
estimation work.
- * The difference between a [[KnownSizeEstimation]] and
+ * When a class extends it, [[SizeEstimator]] will query the `estimatedSize`,
and use
+ * the returned size as the size of the object. Otherwise, [[SizeEstimator]]
will do
Review comment:
Oh I see, makes sense. But I wonder what the "Otherwise" case is now?
sounds like it always returns something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
