imback82 commented on a change in pull request #34686:
URL: https://github.com/apache/spark/pull/34686#discussion_r755814962
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -1294,13 +1294,25 @@ class DataSourceV2SQLSuite
assert(descriptionDf.collect() === Seq(
Row("Namespace Name", "ns2"),
Row(SupportsNamespaces.PROP_COMMENT.capitalize, "test namespace"),
- Row(SupportsNamespaces.PROP_LOCATION.capitalize, "/tmp/ns_test_2"),
+ Row(SupportsNamespaces.PROP_LOCATION.capitalize,
"file:/tmp/ns_test_2"),
Row(SupportsNamespaces.PROP_OWNER.capitalize, defaultUser),
Row("Properties", ""))
)
}
}
+ test("SPARK-37444: ALTER NAMESPACE .. SET LOCATION using v2 catalog with
empty location") {
+ val ns = "testcat.ns1.ns2"
+ withNamespace(ns) {
+ sql(s"CREATE NAMESPACE IF NOT EXISTS $ns COMMENT " +
+ "'test namespace' LOCATION '/tmp/ns_test_1'")
Review comment:
yes, we should fix this. I will do it in a separate PR. Thanks!
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -44,7 +45,8 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
import org.apache.spark.storage.StorageLevel
import org.apache.spark.unsafe.types.UTF8String
-class DataSourceV2Strategy(session: SparkSession) extends Strategy with
PredicateHelper {
+class DataSourceV2Strategy(session: SparkSession) extends Strategy
+ with PredicateHelper with SQLConfHelper {
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
