xinrong-databricks commented on a change in pull request #34354: URL: https://github.com/apache/spark/pull/34354#discussion_r756322349
########## File path: python/pyspark/sql/functions.py ########## @@ -3514,7 +3538,19 @@ def map_from_arrays(col1: "ColumnOrName", col2: "ColumnOrName") -> Column: return Column(sc._jvm.functions.map_from_arrays(_to_java_column(col1), _to_java_column(col2))) +@overload def array(*cols: "ColumnOrName") -> Column: + ... + + +@overload +def array(__cols: Union[List["ColumnOrName"], Tuple["ColumnOrName", ...]]) -> Column: + ... + + +def array( + *cols: Union["ColumnOrName", Union[List["ColumnOrName"], Tuple["ColumnOrName", ...]]] Review comment: Out of curiosity would flattening unions of unions explicitly be better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org