sarutak commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r756506080
##########
File path: project/SparkBuild.scala
##########
@@ -1104,7 +1104,15 @@ object CopyDependencies {
object TestSettings {
import BuildCommons._
- private val defaultExcludedTags = Seq("org.apache.spark.tags.ChromeUITest")
+ private val isMacOnAppleSilicon =
System.getProperty("os.name").startsWith("Mac OS X") &&
+ System.getProperty("os.arch").equals("aarch64")
+ private val defaultExcludedTags = if (isMacOnAppleSilicon) {
+ Seq("org.apache.spark.tags.ChromeUITest",
+ "org.apache.spark.tags.ExtendedLevelDBTest",
+ "org.apache.spark.tags.ExtendedRocksDBTest")
+ } else {
+ Seq("org.apache.spark.tags.ChromeUITest")
+ }
Review comment:
How about:
```suggestion
private val defaultExcludedTags =
Seq("org.apache.spark.tags.ChromeUITest") ++
if (isMacOnAppleSilicon) {
Seq("org.apache.spark.tags.ExtendedLevelDBTest",
"org.apache.spark.tags.ExtendedRocksDBTest")
} else {
Seq.empty
}
```
rather than duplicate `ChromeUITest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
