Github user harsha2010 commented on the pull request:
https://github.com/apache/spark/pull/5830#issuecomment-101007802
Hi Joseph., these updates are required for MetadataUtils.numClasses to work.
If the number of classes is not set in label metadata, the code without
these changes throws an exception instead of returning None
On Mon, May 11, 2015 at 11:08 AM, jkbradley <[email protected]>
wrote:
> @harsha2010 <https://github.com/harsha2010> I'll make a pass now (but let
> me know if I should wait). One early comment: Can you please remove the
> updates with UnresolvedAttribute? That seems unrelated to OneVsRest, so
> hopefully that can go in another PR (and probably with some JIRA notes on
> why it's needed). Thanks!
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/5830#issuecomment-101001664>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
