cloud-fan commented on a change in pull request #34702:
URL: https://github.com/apache/spark/pull/34702#discussion_r756860442
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -423,6 +423,9 @@ object QueryExecution {
PlanSubqueries(sparkSession),
RemoveRedundantProjects,
EnsureRequirements(),
+ // `ReplaceHashWithSortAgg` needs to be added after `EnsureRequirements`
to guarantee the
Review comment:
Is it because the planner is top-down so we don't know the child
ordering during planning? Then we have to add a new rule to change the agg
algorithm in a post-hoc way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
