cloud-fan commented on a change in pull request #34713:
URL: https://github.com/apache/spark/pull/34713#discussion_r756954177
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowNamespacesSuiteBase.scala
##########
@@ -64,24 +66,12 @@ trait ShowNamespacesSuiteBase extends QueryTest with
DDLCommandTestUtils {
withNamespace(s"$catalog.ns1", s"$catalog.ns2") {
sql(s"CREATE NAMESPACE $catalog.ns1")
sql(s"CREATE NAMESPACE $catalog.ns2")
- Seq(
- s"SHOW NAMESPACES IN $catalog LIKE 'ns2'",
- s"SHOW NAMESPACES IN $catalog 'ns2'",
- s"SHOW NAMESPACES FROM $catalog LIKE 'ns2'",
- s"SHOW NAMESPACES FROM $catalog 'ns2'").foreach { sqlCmd =>
Review comment:
We don't need to repeat the parser tests in end-to-end test
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowNamespacesSuiteBase.scala
##########
@@ -64,24 +66,12 @@ trait ShowNamespacesSuiteBase extends QueryTest with
DDLCommandTestUtils {
withNamespace(s"$catalog.ns1", s"$catalog.ns2") {
sql(s"CREATE NAMESPACE $catalog.ns1")
sql(s"CREATE NAMESPACE $catalog.ns2")
- Seq(
- s"SHOW NAMESPACES IN $catalog LIKE 'ns2'",
- s"SHOW NAMESPACES IN $catalog 'ns2'",
- s"SHOW NAMESPACES FROM $catalog LIKE 'ns2'",
- s"SHOW NAMESPACES FROM $catalog 'ns2'").foreach { sqlCmd =>
- withClue(sqlCmd) {
- runShowNamespacesSql(sqlCmd, Seq("ns2"))
- }
- }
+ runShowNamespacesSql(s"SHOW NAMESPACES IN $catalog LIKE 'ns2'",
Seq("ns2"))
}
}
test("does not match to any namespace") {
- Seq(
- "SHOW DATABASES LIKE 'non-existentdb'",
- "SHOW NAMESPACES 'non-existentdb'").foreach { sqlCmd =>
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
