venkata91 commented on a change in pull request #33896:
URL: https://github.com/apache/spark/pull/33896#discussion_r757073030
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1630,6 +1652,53 @@ private[spark] class DAGScheduler(
}
}
+ private[scheduler] def checkAndScheduleShuffleMergeFinalize(
+ shuffleStage: ShuffleMapStage): Unit = {
+ // Check if a finalize task has already been scheduled. This is to prevent
the
+ // following scenario: Stage A attempt 0 fails and gets retried. Stage A
attempt 1
+ // succeeded, triggering the scheduling of shuffle merge finalization.
However,
+ // tasks from Stage A attempt 0 might still be running and sending task
completion
+ // events to DAGScheduler. This check prevents multiple attempts to
schedule merge
+ // finalization get triggered due to this.
Review comment:
Addressed it. Let me know if this looks good or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
