sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-979429513
@cloud-fan In our case, the first function we looked into was `floor`/`ceil` but since it didn't take the scale parameter we had to look for other ways. So i believe adding a `scale` parameter to floor/ceil is a good idea and also I believe the rounding of negative numbers are not so common. If everyone agree I will open a new PR for the scale parameter to `floor`/`ceil` function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
