c21 commented on a change in pull request #34702:
URL: https://github.com/apache/spark/pull/34702#discussion_r757725944
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##########
@@ -694,7 +694,8 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
}
test("SPARK-25497: LIMIT within whole stage codegen should not consume all
the inputs") {
- withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "true") {
+ withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "true",
+ SQLConf.REPLACE_HASH_WITH_SORT_AGG_ENABLED.key -> "false") {
Review comment:
This unit test is testing multiple limit operators and hash aggregate
operators in one single stage. Disable the rule here because sort aggregate
does not support code-gen now, and will break the test logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
