itholic commented on pull request #34717: URL: https://github.com/apache/spark/pull/34717#issuecomment-981182023
> I noticed that `IntegralExtensionOpsTest.test_invert` fails on Pandas 1.0.0 and succeeds on 1.0.1 (error below). So maybe safer to recommend that version. Otherwise everything seems to work with 1.0.0. Yeah, it seems the bug in pandas 1.0.0. - pandas 1.0.0 ```python >>> pser = pd.Series([1, 2, 3, None], dtype="Int8") >>> pser 0 1 1 2 2 3 3 <NA> dtype: Int8 >>> ~pser 0 -2 1 -3 2 -4 3 <NA> dtype: object # this should've been `Int8` ``` Resolved in pandas 1.0.1. - pandas 1.0.1 ```python >>> pser = pd.Series([1, 2, 3, None], dtype="Int8") >>> pser 0 1 1 2 2 3 3 <NA> dtype: Int8 >>> ~pser 0 -2 1 -3 2 -4 3 <NA> dtype: Int8 ``` For addressing this, 1. manually separate this test for pandas 1.0.0. 2. set the minimum pandas to version 1.0.1. Not sure which way is better, but I think we can just go with `2` if there is no reason to stick with the 1.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
