dongjoon-hyun commented on a change in pull request #33588:
URL: https://github.com/apache/spark/pull/33588#discussion_r758063667
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
##########
@@ -143,6 +143,13 @@ abstract class OrcTest extends QueryTest with
FileBasedDataSourceTest with Befor
spark.read.orc(file.getAbsolutePath)
}
+ def withAllOrcReaders(code: => Unit): Unit = {
Review comment:
Hi, All.
This naming is misleading because this only tests `native` ORC reader.
Apache Spark provides `hive` ORC reader, too.
Instead of `withAllOrcReaders`, let's use `withAllNativeOrcReaders`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
