zero323 commented on a change in pull request #34731:
URL: https://github.com/apache/spark/pull/34731#discussion_r758235901
##########
File path: python/pyspark/profiler.py
##########
@@ -31,54 +36,51 @@ class ProfilerCollector(object):
the different stages.
"""
- def __init__(self, profiler_cls, dump_path=None):
- self.profiler_cls = profiler_cls
- self.profile_dump_path = dump_path
- self.profilers = []
+ def __init__(self, profiler_cls: Type["Profiler"], dump_path:
Optional[str] = None):
+ self.profiler_cls: Type[Profiler] = profiler_cls
+ self.profile_dump_path: Optional[str] = dump_path
+ self.profilers: List[Tuple[int, Profiler, bool]] = []
Review comment:
It seems like we should change this to `List[List[Any]]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
