Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6003#issuecomment-101064287
Thanks. I finally had time to review this in detail. A few things we need:
1. There are lot of branches for testing various input types. We should
test those as well in tests.py. (Not in docstring tests).
2. We should support the case where to_replace is just a dict, like Pandas
does.
3. Ideally, we should also support the case where to_replace is a tuple,
and value is just a single value. The semantics is that for all values in
to_replace, just replace it with value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
