cloud-fan commented on a change in pull request #34747:
URL: https://github.com/apache/spark/pull/34747#discussion_r759061265
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -424,27 +422,21 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
|the ${ordinalNumber(ti + 1)} table has
${child.output.length} columns
""".stripMargin.replace("\n", " ").trim())
}
- val isUnion = operator.isInstanceOf[Union]
- val dataTypesAreCompatibleFn = if (isUnion) {
- (dt1: DataType, dt2: DataType) =>
- !DataType.equalsStructurally(dt1, dt2, true)
- } else {
- // SPARK-18058: we shall not care about the nullability of
columns
- (dt1: DataType, dt2: DataType) =>
- TypeCoercion.findWiderTypeForTwo(dt1.asNullable,
dt2.asNullable).isEmpty
- }
+ val dataTypesAreCompatibleFn =
getDataTypesAreCompatibleFn(operator)
// Check if the data types match.
dataTypes(child).zip(ref).zipWithIndex.foreach { case ((dt1,
dt2), ci) =>
// SPARK-18058: we shall not care about the nullability of
columns
if (dataTypesAreCompatibleFn(dt1, dt2)) {
+ operator.setTagValue(DATA_TYPE_MISMATCH_ERROR, true)
Review comment:
do we need to set the tag here? it's always the root node and it's very
easy to find it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
