ueshin commented on a change in pull request #34731:
URL: https://github.com/apache/spark/pull/34731#discussion_r759673223
##########
File path: python/pyspark/profiler.py
##########
@@ -31,54 +36,51 @@ class ProfilerCollector(object):
the different stages.
"""
- def __init__(self, profiler_cls, dump_path=None):
- self.profiler_cls = profiler_cls
- self.profile_dump_path = dump_path
- self.profilers = []
+ def __init__(self, profiler_cls: Type["Profiler"], dump_path:
Optional[str] = None):
+ self.profiler_cls: Type[Profiler] = profiler_cls
+ self.profile_dump_path: Optional[str] = dump_path
+ self.profilers: List[Tuple[int, Profiler, bool]] = []
Review comment:
Got it. I think we can change it but not sure. Anyway we should do it in
a separate PR if needed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
