wForget commented on a change in pull request #34489: URL: https://github.com/apache/spark/pull/34489#discussion_r759919910
########## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHiveSingleton.scala ########## @@ -27,9 +27,9 @@ import org.apache.spark.sql.hive.client.HiveClient trait TestHiveSingleton extends SparkFunSuite with BeforeAndAfterAll { override protected val enableAutoThreadAudit = false - protected val spark: SparkSession = TestHive.sparkSession - protected val hiveContext: TestHiveContext = TestHive - protected val hiveClient: HiveClient = + protected lazy val spark: SparkSession = TestHive.sparkSession + protected lazy val hiveContext: TestHiveContext = TestHive + protected lazy val hiveClient: HiveClient = Review comment: > Could you add some comment to explain why these three lazy are required, please? OK, I want to make the spark.sql.test.master configuration effective in the test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org