cloud-fan commented on a change in pull request #34753:
URL: https://github.com/apache/spark/pull/34753#discussion_r759970181



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala
##########
@@ -200,6 +200,32 @@ abstract class ShowCreateTableSuite extends QueryTest with 
SQLTestUtils {
     }
   }
 
+  test("SPARK-37494: Unify v1 and v2 option output") {
+    withTable("ddl_test") {
+      sql(
+        s"""CREATE TABLE ddl_test (
+           |  a STRING
+           |)
+           |USING json
+           |TBLPROPERTIES (
+           | 'a' = '1',
+           | 'b' = '2')
+           |OPTIONS (
+           | 'k1' = 'v1',
+           | k2 = 'v2',
+           | `k3` 'v3',
+           | k4 'v4',

Review comment:
       can we randomly order the properties and options to test the ordering 
fix? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to