HyukjinKwon commented on pull request #34774: URL: https://github.com/apache/spark/pull/34774#issuecomment-985096653
> I notice that `kwargs` of both SQLStringFormatter and PandasSQLStringFormatter is of `Mapping[str, Any]`. They seem to accept different types of `kwargs` though. Shall we be more specific about the type, which may also act as documentation? I am also fine with the current typing. Actually `kwargs` seems requiring to have value's type only (see https://www.python.org/dev/peps/pep-0484/#arbitrary-argument-lists-and-default-argument-values). Since it can be any type, `Any` looks correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
