cloud-fan commented on a change in pull request #34738:
URL: https://github.com/apache/spark/pull/34738#discussion_r761940490
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -249,12 +250,30 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
def applyLimit(plan: LogicalPlan): LogicalPlan = plan.transform {
case globalLimit @ Limit(IntegerLiteral(limitValue), child) =>
child match {
- case ScanOperation(_, filter, sHolder: ScanBuilderHolder) if
filter.length == 0 =>
+ case ScanOperation(_, filter, sHolder: ScanBuilderHolder) if
filter.isEmpty =>
val limitPushed = PushDownUtils.pushLimit(sHolder.builder,
limitValue)
if (limitPushed) {
sHolder.pushedLimit = Some(limitValue)
}
globalLimit
+ case Sort(order, _, ScanOperation(_, filter, sHolder:
ScanBuilderHolder))
+ if filter.isEmpty =>
+ val orders = DataSourceStrategy.translateSortOrders(order)
+ val topNPushed = PushDownUtils.pushTopN(sHolder.builder,
orders.toArray, limitValue)
+ if (topNPushed) {
+ sHolder.pushedLimit = Some(limitValue)
+ sHolder.sortValues = orders
+ }
+ globalLimit
Review comment:
shall we remove the Sort node from the plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
