thejdeep commented on a change in pull request #34607:
URL: https://github.com/apache/spark/pull/34607#discussion_r762073166
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -600,6 +600,17 @@ private[spark] class AppStatusListener(
liveUpdate(task, now)
Option(liveStages.get((event.stageId, event.stageAttemptId))).foreach {
stage =>
+ if (event.taskInfo.speculative) {
+ stage.speculationStageSummary = Some(stage.speculationStageSummary
+ .getOrElse(new LiveSpeculationStageSummary(event.stageId,
event.stageAttemptId)))
+ val speculationSummary = stage.speculationStageSummary.get
+ speculationSummary.numActiveTasks += 1
+ speculationSummary.numTasks += 1
+ }
+ if(stage.speculationStageSummary.isDefined) {
+ maybeUpdate(stage.speculationStageSummary.get, now)
Review comment:
Since we are indexing by stageId and stageAttemptId, wont the second
call to update overwrite the first ?
For example,
```
speculationSummary.numActiveTasks +=1
update(speculationSummary, now)
speculationSummary = new LiveStageSpeculationSummary(id, attempt)
update(speculationSummary, now)
```
The second update will overwrite the first one, right ? And for the stage,
the speculation summary will show 0 tasks as the default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
