LuciferYang commented on a change in pull request #34760:
URL: https://github.com/apache/spark/pull/34760#discussion_r762552321
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -908,7 +908,7 @@ private[spark] class LiveMiscellaneousProcess(val
processId: String,
var isActive = true
var totalCores = 0
val addTime = new Date(creationTime)
- var removeTime: Date = null
+ val removeTime: Date = null
Review comment:
@srowen
There are 2 `removeTime` in `LiveEntity.scala`:
one is defined in `LiveExecutor`
https://github.com/apache/spark/blob/feba5ac32f2598f6ca8a274850934106be0db64d/core/src/main/scala/org/apache/spark/status/LiveEntity.scala#L262-L272
and the other one defined in `LiveMiscellaneousProcess`
https://github.com/apache/spark/blob/feba5ac32f2598f6ca8a274850934106be0db64d/core/src/main/scala/org/apache/spark/status/LiveEntity.scala#L904-L912
The `removeTime` defined in `LiveExecutor` is modified in
`AppStatusListener` but this PR does not change its definition.
This PR change the definition of `removeTime` in
`LiveMiscellaneousProcess` because it has not been modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
