Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5972#discussion_r30100382
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala
---
@@ -35,6 +35,7 @@ class ConstantFoldingSuite extends PlanTest {
Batch("AnalysisNodes", Once,
EliminateSubQueries) ::
Batch("ConstantFolding", Once,
+ OptimizeIn,
ConstantFolding,
BooleanSimplification) :: Nil
--- End diff --
The initial plan here was to only include the rules we are testing. I'm
not sure if its true here, but sometimes including all the rules make it harder
to test since then you need something that won't be optimized away by unrelated
rules.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
