dchvn opened a new pull request #34819:
URL: https://github.com/apache/spark/pull/34819


   ### What changes were proposed in this pull request?
   1. Move the `DROP NAMESPACE` parsing tests from `DDLParserSuite` to 
`DropNamespaceParserSuite`
   2. Define the class `command.DropNamespaceSuiteBase` that is parent of 
`v1.DropNamespaceSuiteBase` and `v2.DropNamespaceSuite`.
   3. Define the class `v1.DropNamespaceSuiteBase` that is parent of 
`v1.DropNamespaceSuite` and `hive.execution.command.DropNamespaceSuite`.
   4. Place the v1 tests for `DROP NAMESPACE` from `DDLSuite` and v2 tests from 
`DataSourceV2SQLSuite` to the common trait `DropNamespaceSuiteBase`.
   5. Move TODO test from `DescribeNamespaceSuiteBase` to 
`v1.DropNamespaceSuiteBase` and `v2.DropNamespaceSuite`
   
   The changes follow the approach of 
[#30287](https://github.com/apache/spark/pull/30287)
   
   ### Why are the changes needed?
   1. The unification will allow to run common `DROP NAMESPACE` tests for both 
DSv1/Hive DSv1 and DSv2
   2. We can detect missing features and differences between DSv1 and DSv2 
implementations.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   v1/v2 and Hive v1 DropNamespaceSuite:
   
   ```$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly 
*DropNamespaceSuite"```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to