cloud-fan commented on a change in pull request #34819: URL: https://github.com/apache/spark/pull/34819#discussion_r762967427
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DropNamespaceSuite.scala ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.v1 + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.execution.command + +/** + * This base suite contains unified tests for the `DROP NAMESPACE` commands that check V1 table + * catalogs. The tests that cannot run for all V1 catalogs are located in more specific test + * suites: + * + * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.DropNamespaceSuite` + * - V1 Hive External catalog: `org.apache.spark.sql.hive.execution.command.DropNamespaceSuite` + */ +trait DropNamespaceSuiteBase extends command.DropNamespaceSuiteBase { + override protected def builtinTopNamespaces: Seq[String] = Seq("default") + + test("DropNamespace: drop default namespace") { + val message = intercept[AnalysisException] { + sql(s"DROP NAMESPACE default") + }.getMessage + assert(message.contains("Can not drop default database")) + } + + test("DropNamespace: drop non-empty namespace with a non-cascading mode") { + sql(s"CREATE NAMESPACE $catalog.ns") + sql(s"CREATE TABLE $catalog.ns.table (id bigint) $defaultUsing") + checkNamespace(s"SHOW NAMESPACES IN $catalog", Seq("ns") ++ builtinTopNamespaces) + + def assertDropFails(): Unit = { + val e = intercept[AnalysisException] { + sql(s"DROP NAMESPACE $catalog.ns") + } + assert(e.getMessage.contains("Database ns is not empty. One or more tables exist")) + } + + // $catalog.ns.table is present, thus $catalog.ns cannot be dropped. + assertDropFails() + sql(s"DROP TABLE $catalog.ns.table") + + // Now that $catalog.ns is empty, it can be dropped. + sql(s"DROP NAMESPACE $catalog.ns") + checkNamespace(s"SHOW NAMESPACES IN $catalog", builtinTopNamespaces) + } + + test("DropNamespace: Namespace does not exist") { + // Namespace $catalog.unknown does not exist. + val message = intercept[AnalysisException] { + sql(s"DROP DATABASE $catalog.unknown") + }.getMessage + assert(message.contains(s"Database 'unknown' not found")) Review comment: do these 2 exceptions both extends `AnalysisException`? We can check that instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
